New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node version requirements for v10 to v12 #7409
Conversation
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Codecov Report
@@ Coverage Diff @@
## documentation #7409 +/- ##
=================================================
+ Coverage 19.14% 26.17% +7.03%
=================================================
Files 855 1130 +275
Lines 11933 15414 +3481
Branches 1898 2439 +541
=================================================
+ Hits 2284 4034 +1750
- Misses 8100 9561 +1461
- Partials 1549 1819 +270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think it supports node v14 now. Need to do a test with travis |
I don't believe sharp has updated their binaries they ship which is where I see most of the issues. -> libvips which is used by sharp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexandrebodin @petersg83 @lauriejim Whoever does the next release, make sure this gets pulled into the master as well, as it updates all the packages package.json as well as the main README.md |
Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com
Description of what you did:
As Strapi does not support Node v13/v14 I've updated all the requirements and made a few notes in the Documentation as well as the README.md and changed all of the packages to reference the node engine based on: https://docs.npmjs.com/files/package.json#engines
@alexandrebodin I am submitting this into the documentation branch but this will also need to be merged into master to update all the package node engine versions (after we test with things like Heroku which do use that engine version)