Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version requirements for v10 to v12 #7409

Merged
merged 1 commit into from Sep 2, 2020

Conversation

derrickmehaffy
Copy link
Member

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

Description of what you did:

As Strapi does not support Node v13/v14 I've updated all the requirements and made a few notes in the Documentation as well as the README.md and changed all of the packages to reference the node engine based on: https://docs.npmjs.com/files/package.json#engines

@alexandrebodin I am submitting this into the documentation branch but this will also need to be merged into master to update all the package node engine versions (after we test with things like Heroku which do use that engine version)

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #7409 into documentation will increase coverage by 7.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7409      +/-   ##
=================================================
+ Coverage          19.14%   26.17%   +7.03%     
=================================================
  Files                855     1130     +275     
  Lines              11933    15414    +3481     
  Branches            1898     2439     +541     
=================================================
+ Hits                2284     4034    +1750     
- Misses              8100     9561    +1461     
- Partials            1549     1819     +270     
Flag Coverage Δ
#front 18.27% <ø> (+3.78%) ⬆️
#unit 52.96% <ø> (+13.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <0.00%> (-15.66%) ⬇️
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2e2c1...8ebeb4e. Read the comment docs.

@alexandrebodin
Copy link
Member

I think it supports node v14 now. Need to do a test with travis

@derrickmehaffy
Copy link
Member Author

derrickmehaffy commented Aug 11, 2020

I don't believe sharp has updated their binaries they ship which is where I see most of the issues. -> libvips which is used by sharp

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 2, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 2, 2020
@alexandrebodin alexandrebodin merged commit 024b337 into documentation Sep 2, 2020
@alexandrebodin alexandrebodin deleted the fixNodeReferences branch September 2, 2020 15:12
@derrickmehaffy
Copy link
Member Author

@alexandrebodin @petersg83 @lauriejim

Whoever does the next release, make sure this gets pulled into the master as well, as it updates all the packages package.json as well as the main README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants