Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sharp module to 0.26.0 #7729

Merged
merged 1 commit into from Sep 4, 2020
Merged

Update sharp module to 0.26.0 #7729

merged 1 commit into from Sep 4, 2020

Conversation

darron1217
Copy link
Contributor

@darron1217 darron1217 commented Sep 4, 2020 •
edited

Related Issue lovell/sharp#2352

I've faced an issue when building electron app with strapi.

Updating version of sharp solved the problem.

Please check and hope be merged soon.

@MattieBelt
Copy link
Collaborator

@derrickmehaffy, they have updated their libvips version. #7409 might me related.

@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited

Codecov Report

Merging #7729 into master will increase coverage by 0.03%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7729      +/-   ##
==========================================
+ Coverage   27.16%   27.20%   +0.03%     
==========================================
  Files        1163     1164       +1     
  Lines       15518    15517       -1     
  Branches     2410     2410              
==========================================
+ Hits         4216     4221       +5     
+ Misses       9534     9528       -6     
  Partials     1768     1768
Flag Coverage Δ
#front 19.36% <63.63%> (+0.04%) ⬆️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
.../admin/src/components/ComponentIconPicker/index.js 0.00% <0.00%> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 68.75% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
...ovider/utils/getFieldsActionMatchingPermissions.js 100.00% <100.00%> (ø)
...ditViewDataManagerProvider/utils/tests/testData.js 100.00% <100.00%> (ø)
...rc/containers/InputModalStepperProvider/reducer.js 68.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ef1d4...d025f86. Read the comment docs.

@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 4, 2020
@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 4, 2020
alexandrebodin
alexandrebodin approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin
Copy link
Member

Thanks for the upgrade !

@alexandrebodin alexandrebodin merged commit b3bb9f6 into strapi:master Sep 4, 2020
gfritzdev pushed a commit to gfritzdev/strapi that referenced this pull request Sep 7, 2020
@darron1217
Update sharp module to 0.26.0 (strapi#7729)
0d6f483 
Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
@peteretelej
Copy link
Contributor

peteretelej commented Sep 20, 2020 •
edited

sharp 0.26.0 requires Node 10.16.0+ https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020

strapi README may need updating to reflect the new Node version requirement https://github.com/strapi/strapi#-requirements

peteretelej added a commit to peteretelej/strapi that referenced this pull request Sep 20, 2020
@peteretelej
Bump up minimum required Node to 10.16
d4ba941 
Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( strapi#7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```
@peteretelej peteretelej mentioned this pull request Sep 20, 2020
Merged
peteretelej added a commit to peteretelej/strapi that referenced this pull request Sep 20, 2020
@peteretelej
Bump up minimum required Node to 10.16
57262ef 
Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( strapi#7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```

Signed-off-by: Peter Etelej <peter@etelej.com>
alexandrebodin pushed a commit that referenced this pull request Sep 22, 2020
@peteretelej
Bump up minimum required Node to 10.16 (#7962)
318f20e 
Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( #7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```

Signed-off-by: Peter Etelej <peter@etelej.com>
derappelt pushed a commit to derappelt/strapi that referenced this pull request Sep 23, 2020
@peteretelej
Bump up minimum required Node to 10.16 (strapi#7962)
02a21ce 
Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( strapi#7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```

Signed-off-by: Peter Etelej <peter@etelej.com>
@darron1217 darron1217 deleted the patch-1 branch December 11, 2020 13:04
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:upload Source is core/upload package
Projects
None yet
Milestone
3.1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darron1217 @MattieBelt @alexandrebodin @peteretelej