Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email.md #7769

Merged
merged 2 commits into from Sep 14, 2020
Merged

Update email.md #7769

merged 2 commits into from Sep 14, 2020

Conversation

divineforge
Copy link
Contributor

@divineforge divineforge commented Sep 7, 2020

Description of what you did:

to emphasize the part that developer need to pay attention to, especially the file name of plugins.js, and also rewrite the part of the sentences on updating default sender email to make it works with the new email provider. Such that those who read this documentation could better understand those important points, and avoid hours of troubleshooting the configuration, (like what I had.) :)

to emphasize the part that developer need to pay attention to, especially the file name, and rewrite the part of the sentences on updating default sender email to make it works with the new email provider. Such that those who read this documentation could avoid hours of troubleshooting this configuration, (like what I had)

Signed-off-by: William Cheong Weelau <cheongweelau@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #7769 into documentation will increase coverage by 8.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7769      +/-   ##
=================================================
+ Coverage          19.14%   27.16%   +8.02%     
=================================================
  Files                855     1163     +308     
  Lines              11933    15518    +3585     
  Branches            1898     2410     +512     
=================================================
+ Hits                2284     4215    +1931     
- Misses              8100     9535    +1435     
- Partials            1549     1768     +219     
Flag Coverage Δ
#front 19.31% <ø> (+4.82%) ⬆️
#unit 53.85% <ø> (+13.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...api-plugin-users-permissions/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f843718...e5db229. Read the comment docs.

Added the missing `:::` to close the newly added tip paragraph

Signed-off-by: William Cheong Weelau <cheongweelau@gmail.com>
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants