New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update email.md #7769
Update email.md #7769
Conversation
to emphasize the part that developer need to pay attention to, especially the file name, and rewrite the part of the sentences on updating default sender email to make it works with the new email provider. Such that those who read this documentation could avoid hours of troubleshooting this configuration, (like what I had) Signed-off-by: William Cheong Weelau <cheongweelau@gmail.com>
Codecov Report
@@ Coverage Diff @@
## documentation #7769 +/- ##
=================================================
+ Coverage 19.14% 27.16% +8.02%
=================================================
Files 855 1163 +308
Lines 11933 15518 +3585
Branches 1898 2410 +512
=================================================
+ Hits 2284 4215 +1931
- Misses 8100 9535 +1435
- Partials 1549 1768 +219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Added the missing `:::` to close the newly added tip paragraph Signed-off-by: William Cheong Weelau <cheongweelau@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of what you did:
to emphasize the part that developer need to pay attention to, especially the file name of
plugins.js
, and also rewrite the part of the sentences on updating default sender email to make it works with the new email provider. Such that those who read this documentation could better understand those important points, and avoid hours of troubleshooting the configuration, (like what I had.) :)