New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): allow listening on unix socket through server.socket
config
#7824
feat(server): allow listening on unix socket through server.socket
config
#7824
Conversation
…configuration Signed-off-by: Adam Lee <duo1123@gmail.com>
1ccd3b8
to
5451c7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7824 +/- ##
==========================================
+ Coverage 27.16% 32.71% +5.54%
==========================================
Files 1163 1194 +31
Lines 15518 12965 -2553
Branches 2410 1279 -1131
==========================================
+ Hits 4216 4241 +25
+ Misses 9534 7884 -1650
+ Partials 1768 840 -928
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello @admosity hank you for this, it looks good to me. We are just going to ask you to add some documentation :) I think this should be added here: https://strapi.io/documentation/v3.x/concepts/configurations.html#server |
Signed-off-by: Adam Lee <duo1123@gmail.com>
10b1a4e
to
8e7ec90
Compare
@alexandrebodin Sure thing! Just added documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks !
This PR provides the ability to bind to a unix socket. This need came about from the default nginx build pack on heroku requiring to listen on a socket:
https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-nginx#buildpack-instructions
This PR allows the instantiation of the server with the socket:
I can use
server.port
to achieve the same functionality, but the results are a little surprising (and it still works!):