Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heroku guide to set database settings in proper env path #8165

Merged
merged 2 commits into from Oct 6, 2020

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Oct 2, 2020

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

Description of what you did:

closes #8164

The documentation was not clear as it was replacing the SQLite config, making it difficult to understand for new users how to run locally.

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Oct 2, 2020
@derrickmehaffy derrickmehaffy added this to the 3.2.0 milestone Oct 2, 2020
@derrickmehaffy derrickmehaffy self-assigned this Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #8165 into documentation will increase coverage by 13.64%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           documentation    #8165       +/-   ##
==================================================
+ Coverage          19.14%   32.78%   +13.64%     
==================================================
  Files                855     1197      +342     
  Lines              11933    13020     +1087     
  Branches            1898     1286      -612     
==================================================
+ Hits                2284     4268     +1984     
+ Misses              8100     7907      -193     
+ Partials            1549      845      -704     
Flag Coverage Δ
#front 24.81% <ø> (+10.32%) ⬆️
#unit 53.88% <ø> (+13.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...api-plugin-users-permissions/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 75.00% <0.00%> (-25.00%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 42.30% <0.00%> (-24.36%) ⬇️
...admin/src/containers/LanguageProvider/selectors.js 50.00% <0.00%> (-21.43%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 20.33% <0.00%> (-18.07%) ⬇️
...-admin/admin/src/containers/HomePage/components.js 40.00% <0.00%> (-17.15%) ⬇️
... and 1269 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65308ae...b8bd0b7. Read the comment docs.

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants