Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heroku guide to set database settings in proper env path #8165

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Fix heroku guide to set database settings in proper env path #8165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac93e2
Fix heroku guide to set database settings in proper env path
derrickmehaffy Oct 2, 2020
b8bd0b7
PR feedback from Megane
derrickmehaffy Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/v3.x/deployment/heroku.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ With yarn:
yarn add pg-connection-string
```

#### 4. Update your database config file
#### 4. Create your Heroku database config file

Replace the contents of `database.js` with the following:
Create a new `database.js` in a new [env](../concepts/configurations.html#environments) folder. By default Heroku applies the `NODE_ENV` environment variable as production. When you run locally you should be using the `./config/database.js` which should be set to use SQLite.

`Path: ./config/database.js`.
`Path: ./config/env/production/database.js`

```js
const parse = require('pg-connection-string').parse;
Expand Down