Fix file info of new uploaded file not being persisted after edit #8244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: henrych4 <singyinhenry@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8244 +/- ##
==========================================
+ Coverage 33.04% 33.06% +0.02%
==========================================
Files 1219 1219
Lines 13573 13582 +9
Branches 1348 1350 +2
==========================================
+ Hits 4485 4491 +6
- Misses 8206 8208 +2
- Partials 882 883 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
soupette
suggested changes
Oct 12, 2020
| @@ -145,6 +145,12 @@ const reducer = (state, action) => | |||
| draftState.selectedFiles = draftState.selectedFiles.filter(file => file && file.id); | |||
| break; | |||
| } | |||
| case 'ON_SUBMIT_EDIT_NEW_FILE': { | |||
There was a problem hiding this comment.
Can you add the related test for this case?
Signed-off-by: henrych4 <singyinhenry@gmail.com>
henrych4
force-pushed
the
fix-not-persist-fileInfo
branch
from
e9b5cd3
to
a950c51
Compare
soupette
approved these changes
Oct 14, 2020
soupette
added
source: core:upload
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1 |
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
fix #8097
dispatch an action to update file info after edited a new uploaded file.