better error handling for missing model error #8328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Chezieres <tchezieres@MacBook-Pro.lan>
TC-42-54
force-pushed
the
models-missing-collection-error-handling
branch
from
7717bc4
to
5020233
Compare
Signed-off-by: Thomas Chezieres <tchezieres@MacBook-Pro.lan>
TC-42-54
force-pushed
the
models-missing-collection-error-handling
branch
from
56dee67
to
8304869
Compare
Codecov Report
@@ Coverage Diff @@
## master #8328 +/- ##
==========================================
- Coverage 33.20% 33.19% -0.01%
==========================================
Files 1220 1220
Lines 13610 13612 +2
Branches 1355 1356 +1
==========================================
Hits 4519 4519
- Misses 8208 8209 +1
- Partials 883 884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
approved these changes
Oct 15, 2020
alexandrebodin
added
source: core:database
You're welcome, it's a pleasure to work with Strapi 😃 |
This was referenced Mar 10, 2021
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Actually, if a model is missing from the configuration but present in the database, you get the following error message:
[2020-10-14T09:17:43.597Z] debug ⛔️ Server wasn't able to start properly. [2020-10-14T09:17:43.599Z] error TypeError: Cannot read property 'attributes' of undefined at Object.getNature (/usr/app/node_modules/strapi-utils/lib/models.js:83:61) at Object.keys.forEach.name (/usr/app/node_modules/strapi-connector-bookshelf/lib/mount-models.js:127:21) at Array.forEach (<anonymous>) at Object.keys.map (/usr/app/node_modules/strapi-connector-bookshelf/lib/mount-models.js:120:40)The problem is it doesn't let you know which model is causing the error.
I just added an error handling statement to show which model is blocking the server from starting.