Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error handling for missing model error #8328

Merged
merged 4 commits into from
Oct 15, 2020
Merged

better error handling for missing model error #8328

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5020233
Ammending commit
Oct 14, 2020
8304869
ammending last commit
Oct 14, 2020
5f59f8a
Merge branch 'master' into models-missing-collection-error-handling
TC-42-54 Oct 14, 2020
2b5b11c
Merge branch 'master' into models-missing-collection-error-handling
alexandrebodin Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/strapi-utils/lib/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ module.exports = {
});
});
} else if (_.has(attribute, 'via') && _.has(attribute, 'collection')) {
if (!_.has(models, attribute.collection)) {
throw new Error(
`The collection \`${_.upperFirst(
attribute.collection
)}\` is missing from the models ${attribute.plugin ? '(plugin - ' + attribute.plugin + ')' : ''}`
TC-42-54 marked this conversation as resolved.
Show resolved Hide resolved
);
}
const relatedAttribute = models[attribute.collection].attributes[attribute.via];

if (!relatedAttribute) {
Expand Down