Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node.js 12 from CI testing #15

Merged
merged 4 commits into from Feb 6, 2023
Merged

Remove Node.js 12 from CI testing #15

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55c8786
Remove Node.js 12 from CI testing
ybiquitous Nov 16, 2022
0fa7c1b
Merge branch 'main' into remove-nodejs-12
ybiquitous Nov 16, 2022
5901f8f
Add workaround for Node.js 14 and Windows
ybiquitous Nov 16, 2022
54438f2
Print the latest npm version
ybiquitous Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ on:
node-version:
description: Node.js version
required: false
default: '["12", "14", "16", "18"]'
default: '["14", "16", "18"]'
type: string
os:
description: OS name
Expand Down Expand Up @@ -41,9 +41,13 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: npm

# HACK: See https://github.com/npm/cli/issues/4341
- name: Workaround for npm installation failure on Node.js 14 and Windows
if: ${{ startsWith(matrix.node-version, '14') && startsWith(matrix.os, 'windows') }}
run: npm install --global npm@8.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] There is a performance penalty (maybe less than 1 minute) in the environment.

Ref: npm/cli#4341


- name: Install latest npm
# TODO: npm@9 is the latest, but it doesn't work on Node.js v12 and v14 with windows.
run: npm install --global npm@8
run: npm install --global npm@latest && npm --version

- name: Install dependencies
run: npm ci
Expand Down