Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js 12 from CI testing #15

Merged
merged 4 commits into from Feb 6, 2023
Merged

Remove Node.js 12 from CI testing #15

merged 4 commits into from Feb 6, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

This pull request is blocked until stylelint/stylelint completely removes Node.js 12.
See also stylelint/stylelint#6477

# HACK: See https://github.com/npm/cli/issues/4341
- name: Workaround for npm installation failure on Node.js 14 and Windows
if: ${{ startsWith(matrix.node-version, '14') && startsWith(matrix.os, 'windows') }}
run: npm install --global npm@8.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] There is a performance penalty (maybe less than 1 minute) in the environment.

Ref: npm/cli#4341

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove Node.js 12 from CI testing Switch npm v8 to npm v9 on CI testing
2 participants