Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jest 27 #35

Merged
merged 1 commit into from May 28, 2021
Merged

Support Jest 27 #35

merged 1 commit into from May 28, 2021

Conversation

ybiquitous
Copy link
Member

Jest 27 has been released! 馃帀
https://jestjs.io/blog/2021/05/25/jest-27

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

This change adds the support of Jest 27. I will create a test PR to the stylelint/stylelint repository.

@ybiquitous
Copy link
Member Author

I will create a test PR to the stylelint/stylelint repository.

Done. See stylelint/stylelint#5326

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous Can I give you npm access to publish a new version?

Should be a patch release, right?

@ybiquitous
Copy link
Member Author

@ybiquitous Can I give you npm access to publish a new version?

Yes, thanks!

Should be a patch release, right?

Maybe. But I'm checking if this change works on some stylelint plugins, so please wait for a while. 馃檹馃徏

@ybiquitous
Copy link
Member Author

When I test this change for plugins on the list below, I find no breaking. 馃憤馃徏
https://github.com/stylelint/jest-preset-stylelint/network/dependents?dependent_type=PACKAGE

I think it's OK to release the next version 4.1.1. 馃槃
https://github.com/stylelint/jest-preset-stylelint/releases

@jeddy3 jeddy3 merged commit 562b6d3 into master May 28, 2021
@jeddy3 jeddy3 deleted the jest-27 branch May 28, 2021 10:00
@jeddy3
Copy link
Member

jeddy3 commented May 28, 2021

Can I give you npm access to publish a new version?

I wasn't able to as I'm only a member of the package. See #23.

@ntwb Is it possible to make me an owner, so I can invite others to the package for future releases?

I think it's OK to release the next version 4.1.1. 馃槃

I've released as 4.1.1.

@ntwb
Copy link
Member

ntwb commented May 28, 2021

@jeddy3 Trying to resolve this now

@ntwb
Copy link
Member

ntwb commented May 28, 2021

@ybiquitous There should be an invite to the stylelint npm org in your email

@ntwb
Copy link
Member

ntwb commented May 28, 2021

I've added this jest-preset-stylelint package to the mpm stylelint org

p.s @jeddy3 you're already an owner, I'll continue to follow up and close out #23 all the same

@ybiquitous
Copy link
Member Author

@jeddy3 Thank you for the release! 馃帀

@ntwb Thank you for the invitation! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants