Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jest from v26 to v27 #5326

Merged
merged 3 commits into from May 28, 2021
Merged

Bump jest from v26 to v27 #5326

merged 3 commits into from May 28, 2021

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented May 26, 2021

https://jestjs.io/blog/2021/05/25/jest-27

Which issue, if any, is this issue related to?

Blocked by stylelint/jest-preset-stylelint/pull/35

Is there anything in the PR that needs further explanation?

This PR is WIP. Now ready to review!
I've taken the following steps to create this change:

# `jest-circus` is now the default runner
npm rm jest-circus

# It seems that a new version will be published soon.
# See https://github.com/jest-community/jest-watch-typeahead/issues/61
npm i jest-community/jest-watch-typeahead --ignore-scripts

# Install Jest 27 and our preset
npm i jest@27 stylelint/jest-preset-stylelint#jest-27

To-dos

  • Use a new version of jest-watch-typeahead
  • Use a new version of jest-preset-stylelint

@ybiquitous ybiquitous added pr: blocked is blocked by another issue or pr pr: dependencies relates to dependencies labels May 26, 2021
package.json Outdated Show resolved Hide resolved
@@ -100,7 +100,6 @@
],
"testEnvironment": "node",
"testRegex": ".*\\.test\\.js$|rules/.*/__tests__/.*\\.js$",
"testRunner": "jest-circus/runner",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] jest-circus is the default runner of Jest 27. See https://jestjs.io/blog/2021/05/25/jest-27#flipping-defaults

@ybiquitous
Copy link
Member Author

Jest 27 has proceeded with the ESM support but is not finished: jestjs/jest#11167

Ref: #5291

@alexander-akait
Copy link
Member

Until Node.js is not supported vm module with ESM without flags https://nodejs.org/api/vm.html#vm_class_vm_module it will be still in progress

@alexander-akait
Copy link
Member

I'm afraid it won't happen soon 😞

@ybiquitous
Copy link
Member Author

@alexander-akait Thanks for sharing. Not so good news. 😓

(I believe that the partial support of ESM does NOT block the merge of this PR.)

@jeddy3 jeddy3 removed the pr: blocked is blocked by another issue or pr label May 28, 2021
@jeddy3
Copy link
Member

jeddy3 commented May 28, 2021

Unblocked as the new version of jest preset is published.

@ybiquitous ybiquitous marked this pull request as ready for review May 28, 2021 11:18
@ybiquitous
Copy link
Member Author

@jeddy3 Thank you for the notification! I've updated jest-preset-stylelint via 5d2c4b7.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous ybiquitous merged commit 783b64a into v14 May 28, 2021
@ybiquitous ybiquitous deleted the jest-27 branch May 28, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Development

Successfully merging this pull request may close these issues.

None yet

3 participants