Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 30.0.0 #277
Prepare 30.0.0 #277
Changes from 12 commits
d9e0957
ca090fb
2caed31
2cf882a
45a9951
adf93aa
24b802e
24764bc
6fd33db
f4f5923
74aa299
1714d1e
afffa70
ee0b935
902d1f1
719d270
1befcab
092b3c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is time consuming, but since the CHANGELOG of the version 15 doesn't contain the list, could you either link the list here or list the rules directly?
I am asking because I almost didn't realise how many rules you were removing; this needs to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I think adding a link to the migration guide like this is enough because the guide describes the deprecated rules. Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This markdown file doesn't have the list so it's easy to miss. At the minimum it should contain the number of rules removed:
stylelint@15.0.0
. For details, see the migration guide.I think the exact number is 64, but that would be misleading if we were not using them all in index.js.
So maybe:
stylelint@15.0.0
. For details, see the migration guide.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've pushed the change afffa70.