Prepare 30.0.0 #277
Prepare 30.0.0 #277
Conversation
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
As we encourage writing modern CSS in this config
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
CHANGELOG.md
Outdated
| ## 30.0.0 | ||
|
|
||
| - Removed: `stylelint` less than `15.0.0` from peer dependencies. | ||
| - Removed: rules deprecated in `stylelint@15.0.0`. |
There was a problem hiding this comment.
I know this is time consuming, but since the CHANGELOG of the version 15 doesn't contain the list, could you either link the list here or list the rules directly?
I am asking because I almost didn't realise how many rules you were removing; this needs to be explicit.
There was a problem hiding this comment.
That makes sense. I think adding a link to the migration guide like this is enough because the guide describes the deprecated rules. Any thoughts?
| - Removed: rules deprecated in `stylelint@15.0.0`. | |
| - Removed: rules deprecated in `stylelint@15.0.0`. For details, see the [migration guide](https://github.com/stylelint/stylelint/blob/15.0.0/docs/migration-guide/to-15.md). |
There was a problem hiding this comment.
This markdown file doesn't have the list so it's easy to miss. At the minimum it should contain the number of rules removed:
- Removed: XX rules deprecated in
stylelint@15.0.0. For details, see the migration guide.
I think the exact number is 64, but that would be misleading if we were not using them all in index.js.
So maybe:
- Removed: 64 out of YY rules deprecated in
stylelint@15.0.0. For details, see the migration guide.
There was a problem hiding this comment.
Thanks, I've pushed the change afffa70.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Closes #274
Closes #244
Updates test and example code to better reflect what the config does.
Doesn't change peer dep as changes don't require it.