-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 30.0.0 #277
Merged
Merged
Prepare 30.0.0 #277
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d9e0957
Prepare 30.0.0
jeddy3 ca090fb
Update CHANGELOG.md
jeddy3 2caed31
Use "modern" in description
jeddy3 2cf882a
Add selector-not-notation CSS to test and example
jeddy3 45a9951
Format with Prettier for continuity
jeddy3 adf93aa
Add test for deprecated rules
jeddy3 24b802e
Update package.json
jeddy3 24764bc
Update changelog
jeddy3 6fd33db
Add changelog entry for `value-no-vendor-prefix`
ybiquitous f4f5923
Update deps in `package-lock.json`
ybiquitous 74aa299
Update CI setting
ybiquitous 1714d1e
Update deps
ybiquitous afffa70
Update CHANGELOG to clarify removed rules
ybiquitous ee0b935
Update .github/workflows/nodejs.yml
jeddy3 902d1f1
Update .github/workflows/nodejs.yml
jeddy3 719d270
Temp broaden peer range for testing
jeddy3 1befcab
Update stylelint deps
jeddy3 092b3c0
Fix URL
jeddy3 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,17 @@ | ||
a { | ||
top: .2em; | ||
} | ||
|
||
@custom-media --FOO; | ||
|
||
:root { --FOO: 1px; } | ||
:root { | ||
--FOO: 1px; | ||
} | ||
|
||
@keyframes FOO { /* ... */ } | ||
@keyframes FOO { | ||
/* ... */ | ||
} | ||
|
||
.FOO { /* ... */ } | ||
.FOO { | ||
/* ... */ | ||
} | ||
|
||
#FOO { /* ... */ } | ||
#FOO { | ||
/* ... */ | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is time consuming, but since the CHANGELOG of the version 15 doesn't contain the list, could you either link the list here or list the rules directly?
I am asking because I almost didn't realise how many rules you were removing; this needs to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I think adding a link to the migration guide like this is enough because the guide describes the deprecated rules. Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This markdown file doesn't have the list so it's easy to miss. At the minimum it should contain the number of rules removed:
stylelint@15.0.0
. For details, see the migration guide.I think the exact number is 64, but that would be misleading if we were not using them all in index.js.
So maybe:
stylelint@15.0.0
. For details, see the migration guide.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've pushed the change afffa70.