Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media-feature-name-unit-allowed-list #6550

Merged
merged 15 commits into from Jan 5, 2023
Merged

Add media-feature-name-unit-allowed-list #6550

merged 15 commits into from Jan 5, 2023

Commits on Dec 30, 2022

  1. First pass: media-feature-name-unit-allowed-list 

    Adds base rule, refactors slightly from @romainmenke's suggestion;
adds docs, rudimentary tests.

Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
    @mattxwang @romainmenke
    mattxwang and romainmenke committed Dec 30, 2022
    Copy the full SHA
    fc2335d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Fix end positions 

    Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
    @mattxwang @romainmenke
    mattxwang and romainmenke committed Jan 3, 2023
    Copy the full SHA
    63afd4c View commit details
    Browse the repository at this point in the history

  2. add tests for feature names with no attached unit

    @mattxwang
    mattxwang committed Jan 3, 2023
    Copy the full SHA
    cb04213 View commit details
    Browse the repository at this point in the history

  3. Properly grabs name for range queries 

    Required a bit of hardcoding?
    @mattxwang
    mattxwang committed Jan 3, 2023
    Copy the full SHA
    7416082 View commit details
    Browse the repository at this point in the history

  4. add changeset

    @mattxwang
    mattxwang committed Jan 3, 2023
    Copy the full SHA
    9d48596 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'v15' into media-feature-name-unit-allowed-list

    @mattxwang
    mattxwang committed Jan 3, 2023
    Copy the full SHA
    c112116 View commit details
    Browse the repository at this point in the history

  6. Uses entry.node.name.getName() 

    Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
    @mattxwang @romainmenke
    mattxwang and romainmenke committed Jan 3, 2023
    Copy the full SHA
    712484e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Update changeset to match naming convention

    @mattxwang
    mattxwang committed Jan 4, 2023
    Copy the full SHA
    d95146f View commit details
    Browse the repository at this point in the history

  2. Update changeset to match naming convention (again) 

    Co-authored-by: Marc G. <Mouvedia@users.noreply.github.com>
    @mattxwang @Mouvedia
    mattxwang and Mouvedia committed Jan 4, 2023
    Copy the full SHA
    898a4c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Merge branch 'main' into media-feature-name-unit-allowed-list

    @mattxwang
    mattxwang committed Jan 5, 2023
    Copy the full SHA
    8b654f1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jan 5, 2023
    Copy the full SHA
    4a3e90b View commit details
    Browse the repository at this point in the history

  3. misc standardization

    @mattxwang
    mattxwang committed Jan 5, 2023
    Copy the full SHA
    9aaf7cb View commit details
    Browse the repository at this point in the history

  4. fix postcss location

    @mattxwang
    mattxwang committed Jan 5, 2023
    Copy the full SHA
    7e5fab8 View commit details
    Browse the repository at this point in the history

  5. Improve readability/conciseness of library code 

    No behaviour changes.

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jan 5, 2023
    Copy the full SHA
    e5aabfe View commit details
    Browse the repository at this point in the history

  6. Merge branch 'v15' into media-feature-name-unit-allowed-list

    @mattxwang
    mattxwang committed Jan 5, 2023
    Copy the full SHA
    61e2dd6 View commit details
    Browse the repository at this point in the history