Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes at-rule-no-unknown false positives for @scroll-timeline #6554

Merged
merged 4 commits into from Jan 4, 2023
Merged

Fixes at-rule-no-unknown false positives for @scroll-timeline #6554

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7626a4b
Fixes `at-rule-no-unknown` false positives for `@scroll-timeline`
mattxwang Jan 3, 2023
8e8a447
Adds changeset
mattxwang Jan 3, 2023
d5587af
adjusts new test case to better match developer conventions
mattxwang Jan 4, 2023
f47e3eb
Update changeset to match naming convention
mattxwang Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-ligers-type.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"stylelint": patch
---

Fixes `at-rule-no-unknown` false positives for `@scroll-timeline`
mattxwang marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions lib/reference/atKeywords.js
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@ const atKeywords = uniteSets(pageMarginAtKeywords, [
'ornaments',
'page',
'property',
'scroll-timeline',
'styleset',
'stylistic',
'supports',
Expand Down
3 changes: 3 additions & 0 deletions lib/rules/at-rule-no-unknown/__tests__/index.js
View file
Open in desktop
Expand Up @@ -91,6 +91,9 @@ testRule({
{
code: '@layer framework { h1 { background: white; } }',
},
{
code: '@scroll-timeline spin-slash { }',
mattxwang marked this conversation as resolved.
Show resolved Hide resolved
},
],

reject: [
Expand Down