Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all rules to ESM again #7262

Merged
merged 3 commits into from Oct 19, 2023
Merged

Migrate all rules to ESM again #7262

merged 3 commits into from Oct 19, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Oct 19, 2023

Which issue, if any, is this issue related to?

Ref #5291
Closes #7211

Is there anything in the PR that needs further explanation?

This PR is a retry of PR #7211, which includes too many conflicts. The following steps made this PR change:

  1. Run node scripts/rewrite-rules-to-esm.mjs
  2. Manually fix lint and test failures

@changeset-bot

This comment was marked as resolved.

1. Run `node scripts/rewrite-rules-to-esm.mjs`
2. Manually fix lint and test failures
@ybiquitous
Copy link
Member Author

ybiquitous commented Oct 19, 2023

Non-migrated files:

$ git ls-files 'lib/**/*.js'
lib/__tests__/__mocks__/stylelint-test-custom-formatter.js
lib/__tests__/fixtures/broken-syntax/stylelint.config.js
lib/__tests__/fixtures/config-require-unknown.js
lib/__tests__/fixtures/custom-parser.js
lib/__tests__/fixtures/custom-syntax.js
lib/__tests__/fixtures/formatters/customFormatter.js
lib/__tests__/fixtures/plugin-array.js
lib/__tests__/fixtures/plugin-async.js
lib/__tests__/fixtures/plugin-conditionally-check-color-named.js
lib/__tests__/fixtures/plugin-primary-array.js
lib/__tests__/fixtures/plugin-slashless-warn-about-foo.js
lib/__tests__/fixtures/plugin-warn-about-bar.js
lib/__tests__/fixtures/plugin-warn-about-foo.js
lib/__tests__/fixtures/postcss-naive-css-in-js.js
lib/__tests__/fixtures/processor-fenced-blocks.js
lib/__tests__/fixtures/processor-triple-question-marks.js

EDIT: I'll open another PR to address the files above.


Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! The previous PR diff was nasty. This LGTM, thanks for splitting these up!

@ybiquitous ybiquitous merged commit 0f28bc6 into v16 Oct 19, 2023
12 of 14 checks passed
@ybiquitous ybiquitous deleted the esm-all-rules-again branch October 19, 2023 23:57
@Mouvedia Mouvedia mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants