Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lightness-notation #7366

Merged
merged 10 commits into from Dec 16, 2023
Merged

Add lightness-notation #7366

merged 10 commits into from Dec 16, 2023

Conversation

fpetrakov
Copy link
Contributor

Closes #7359

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2023 •
edited

⚠️ No Changeset found

Latest commit: c996294

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

romainmenke
romainmenke reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes @fpetrakov

lib/rules/lightness-notation/index.cjs Show resolved Hide resolved
lib/rules/lightness-notation/index.cjs Outdated Show resolved Hide resolved
ybiquitous
ybiquitous requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetrakov Thanks for creating the PR. I don't believe there are major problems. 👍🏼

Can you take a look at my suggestion comments? If you have rationale, you don't need to address all.

docs/user-guide/rules.md Outdated Show resolved Hide resolved
lib/rules/lightness-notation/index.mjs Show resolved Hide resolved
lib/rules/lightness-notation/index.mjs Outdated Show resolved Hide resolved
lib/rules/lightness-notation/index.mjs Outdated Show resolved Hide resolved
lib/rules/lightness-notation/index.mjs Outdated Show resolved Hide resolved
lib/rules/lightness-notation/index.mjs Outdated Show resolved Hide resolved
lib/rules/lightness-notation/README.md Show resolved Hide resolved
@ybiquitous
Copy link
Member

Note: I'd like to merge this PR after the 16.0.0 release (#7374).

@fpetrakov
Copy link
Contributor Author

fpetrakov commented Dec 5, 2023 •
edited

@ybiquitous Thanks for reviewing the PR. All of yours suggestions are sensible, so I will fix things in the coming days

ybiquitous
ybiquitous approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I'll revisit this after the 16.0.0 release.

Also, we need to determine a value (maybe percentage?) added in the standard config before publishing this new rule.

@fpetrakov
Copy link
Contributor Author

Also, we need to determine a value (maybe percentage?) added in the standard config before publishing this new rule.

I agree on percentage

@ybiquitous
Copy link
Member

@fpetrakov Can you resolve the conflicts raised by the 16.0.0 release?

@ybiquitous ybiquitous self-requested a review December 10, 2023 16:53
jeddy3
jeddy3 requested changes Dec 10, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's looking great.

I've requested a change to the README, otherwise LGTM.

lib/rules/lightness-notation/README.md Show resolved Hide resolved
lib/rules/lightness-notation/README.md Show resolved Hide resolved
lib/rules/lightness-notation/README.md Show resolved Hide resolved
lib/rules/lightness-notation/README.md Show resolved Hide resolved
ybiquitous
ybiquitous approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

One more request, can you add a changelog entry via npx changeset add?
Ref https://github.com/stylelint/stylelint/blob/e28036e8c6121e2293a57986998af941ef2acc01/.changeset/early-jobs-hunt.md?plain=1

Mouvedia
Mouvedia reviewed Dec 12, 2023
View reviewed changes
lib/rules/lightness-notation/__tests__/index.mjs
Copy link
Member

@Mouvedia Mouvedia Dec 12, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

Maybe add a fix case using deg.
Or change one or two existing ones to use deg.
i.e. to detect regressions if deg gets stripped

Mouvedia
Mouvedia approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There might be potential futur refactors seeing the similarities between the 2 rules.

jeddy3
jeddy3 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

(The rule falls neatly into the wish of supporting modern CSS in the 16.x)

@jeddy3 jeddy3 merged commit d03def6 into stylelint:main Dec 16, 2023
16 checks passed
This was referenced Dec 20, 2023
Merged
Closed
Merged
ybiquitous added a commit that referenced this pull request Dec 22, 2023
@ybiquitous
Add missing changelog for PR #7366
548b221
@chrisgrieser chrisgrieser mentioned this pull request Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke left review comments

@Mouvedia Mouvedia Mouvedia approved these changes

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lightness-notation
5 participants
@fpetrakov @ybiquitous @Mouvedia @jeddy3 @romainmenke