Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan baseline, eslint config and caching tests #6493

Merged
merged 8 commits into from Mar 2, 2022
Merged

Fix phpstan baseline, eslint config and caching tests #6493

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
87e2655
Update phpstan baseline
alexander-schranz Mar 2, 2022
0bd6409
Adjust eslint rule to behave the same
alexander-schranz Mar 2, 2022
01f76f3
Change S3Storage Tests to getKernelClass
alexander-schranz Mar 2, 2022
ee6b3cc
Fix phpstan
alexander-schranz Mar 2, 2022
4438d9e
Fix caching tests
alexander-schranz Mar 2, 2022
de7b6bf
Update phpstan baseline
alexander-schranz Mar 2, 2022
68bd1e2
Fix S3 lowest storage tests
alexander-schranz Mar 2, 2022
2cb77bc
Add type for phpstan baseline
alexander-schranz Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Expand Up @@ -143,7 +143,11 @@
"react/no-deprecated": "error",
"react/jsx-curly-brace-presence": [
"error",
"never"
{
"props": "never",
"children": "never",
"propElementValues": "always"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new but it is as stated in the following issue / comment jsx-eslint/eslint-plugin-react#3228 (comment) not supported by all parser so we need to define it to always so our parsers do not have problems with it.

}
],
"react/jsx-curly-spacing": [
"error",
Expand Down
23 changes: 19 additions & 4 deletions phpstan-baseline.neon
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ parameters:
path: src/Sulu/Bundle/ActivityBundle/Infrastructure/Symfony/DependencyInjection/SuluActivityExtension.php

-
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|null, mixed given\\.$#"
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|UnitEnum\\|null, mixed given\\.$#"
count: 2
path: src/Sulu/Bundle/ActivityBundle/Infrastructure/Symfony/DependencyInjection/SuluActivityExtension.php

Expand Down Expand Up @@ -21861,7 +21861,7 @@ parameters:
path: src/Sulu/Bundle/MediaBundle/DependencyInjection/SuluMediaExtension.php

-
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|null, mixed given\\.$#"
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|UnitEnum\\|null, mixed given\\.$#"
count: 2
path: src/Sulu/Bundle/MediaBundle/DependencyInjection/SuluMediaExtension.php

Expand Down Expand Up @@ -49451,7 +49451,7 @@ parameters:
path: src/Sulu/Bundle/TestBundle/Kernel/SuluTestKernel.php

-
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|null, mixed given\\.$#"
message: "#^Parameter \\#2 \\$value of method Symfony\\\\Component\\\\DependencyInjection\\\\Container\\:\\:setParameter\\(\\) expects array\\|bool\\|float\\|int\\|string\\|UnitEnum\\|null, mixed given\\.$#"
count: 1
path: src/Sulu/Bundle/TestBundle/Kernel/SuluTestKernel.php

Expand Down Expand Up @@ -59150,6 +59150,21 @@ parameters:
count: 1
path: src/Sulu/Component/Content/Form/DataTransformer/DocumentToUuidTransformer.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Form\\\\FormError\\|Symfony\\\\Component\\\\Form\\\\FormErrorIterator\\:\\:getMessage\\(\\)\\.$#"
count: 1
path: src/Sulu/Component/Content/Form/Exception/InvalidFormException.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Form\\\\FormError\\|Symfony\\\\Component\\\\Form\\\\FormErrorIterator\\:\\:getMessageParameters\\(\\)\\.$#"
count: 1
path: src/Sulu/Component/Content/Form/Exception/InvalidFormException.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Form\\\\FormError\\|Symfony\\\\Component\\\\Form\\\\FormErrorIterator\\:\\:getOrigin\\(\\)\\.$#"
count: 2
path: src/Sulu/Component/Content/Form/Exception/InvalidFormException.php

-
message: "#^Method Sulu\\\\Component\\\\Content\\\\Form\\\\Type\\\\DocumentObjectType\\:\\:buildForm\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -76246,7 +76261,7 @@ parameters:
path: src/Sulu/Component/Rest/Csv/CsvHandler.php

-
message: "#^Offset 'value' does not exist on array\\{value\\: string, type\\: int\\|string\\|null, position\\: int\\}\\|null\\.$#"
message: "#^Offset 'value' does not exist on array\\{value\\: int\\|string, type\\: int\\|string\\|null, position\\: int\\}\\|null\\.$#"
count: 1
path: src/Sulu/Component/Rest/DQL/Cast.php

Expand Down