Fix phpstan baseline, eslint config and caching tests #6493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "props": "never", | ||
| "children": "never", | ||
| "propElementValues": "always" |
There was a problem hiding this comment.
This is a new but it is as stated in the following issue / comment jsx-eslint/eslint-plugin-react#3228 (comment) not supported by all parser so we need to define it to always so our parsers do not have problems with it.
alexander-schranz
changed the title
alexander-schranz
added
the
Bug
alexander-schranz
changed the title
| @@ -38,6 +38,7 @@ public function testFirstRequestIsACacheMiss() | |||
| $cacheKernel = new AppCache(self::bootKernel()); | |||
| $cookieJar = new CookieJar(); | |||
| $client = new KernelBrowser($cacheKernel, [], null, $cookieJar); | |||
| $client->disableReboot(); | |||
There was a problem hiding this comment.
this is now required else other tests are running into an issue about a not booted kernel
alexander-schranz
changed the title
Comment on lines
+24
to
+27
| protected static function getKernelClass(): string | ||
| { | ||
| return S3Kernel::class; | ||
| } |
There was a problem hiding this comment.
required because of: symfony/symfony#45414
We still need to define protected static $class = S3Kernel::class; for prefer lowest tests.
chirimoya
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix phpstan baseline.
Why?
Fix baseline.