New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phpstan baseline, eslint config and caching tests #6493
Merged
wachterjohannes
merged 8 commits into
sulu:2.3
from
alexander-schranz:bugfix/phpstan-baseline
Mar 2, 2022
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87e2655
Update phpstan baseline
alexander-schranz 0bd6409
Adjust eslint rule to behave the same
alexander-schranz 01f76f3
Change S3Storage Tests to getKernelClass
alexander-schranz ee6b3cc
Fix phpstan
alexander-schranz 4438d9e
Fix caching tests
alexander-schranz de7b6bf
Update phpstan baseline
alexander-schranz 68bd1e2
Fix S3 lowest storage tests
alexander-schranz 2cb77bc
Add type for phpstan baseline
alexander-schranz File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new but it is as stated in the following issue / comment jsx-eslint/eslint-plugin-react#3228 (comment) not supported by all parser so we need to define it to always so our parsers do not have problems with it.