Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade $request->get('key') calls on array to $request->all('key'); #6587

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented May 3, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #6556
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Upgrade $request->get('key') calls on array to $request->all('key');

Why?

Symfony does not longer allow to fetch an array from InputBag with get('key') instead all('key') in Symfony 6 need to be used.

All discussions about it see:

@alexander-schranz alexander-schranz added the DX Affecting the end developer label May 3, 2022
@alexander-schranz alexander-schranz mentioned this pull request May 3, 2022
84 tasks
@alexander-schranz alexander-schranz force-pushed the enhancement/role-controller-compatibility branch from 6dab0da to 1d4fad2 Compare May 3, 2022 17:00
@Prokyonn Prokyonn merged commit a05e58a into sulu:2.5 May 3, 2022
alexander-schranz added a commit to alexander-schranz/sulu that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants