Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react-redux v7 #321

Merged
merged 3 commits into from Jul 2, 2019
Merged

Support for react-redux v7 #321

merged 3 commits into from Jul 2, 2019

Conversation

quarties
Copy link
Contributor

I know that it is a duplicate of #303, but it looks like the author of that PR is not currently available, so I decided to create my own.

With current dependenciec all test are passed :-)

@quarties quarties mentioned this pull request Jun 14, 2019
@thisissami
Copy link

Thanks for doing this. :)

I am curious: what is the process like for merging PRs into this project? As somebody who has only been tangentially involved with open source projects in the past - I know quite little about how different projects operate. I'd love to learn a bit about how the decision-making works for a project like this.

@quarties
Copy link
Contributor Author

Thanks for doing this. :)

I am curious: what is the process like for merging PRs into this project? As somebody who has only been tangentially involved with open source projects in the past - I know quite little about how different projects operate. I'd love to learn a bit about how the decision-making works for a project like this.

@thisissami TBH I don't know. I believe that this project is a personal project of @supasate. According to old, similar PRs (like: #273) it looks like this awesome guy is maintaining the repo by his own. And kudos to him!

Protip that I could give you - if you are ever curious how the contribution in open-source project works, check old PRs and CONTRIBUTION.md file if there is any :-)

@bboydflo
Copy link

Hey @quarties, awesome job! I think maybe it's a good idea to update the readme as well. currently it says that reac-redux@7 is not supported, which is exactly what this PR is about.

@janklimo
Copy link

Thank you for this @quarties. Just to confirm, is it safe to bump the version without further changes? I came across the following in the react-redux changelog:

Any library that attempts to access the store instance out of legacy context will break, because we now put the store state into a <Context.Provider> instead. Examples of this include connected-react-router and react-redux-subspace.

Though that's from v6.0 so hopefully that's been resolved since then?

@quarties
Copy link
Contributor Author

@bboydflo good point, I had updated the README.md file as well.

@janklimo I hope so too, I've tested my fork with upgraded react-redux dependencies with my apps that use connected-react-router and everything worked fine. Also, the tests pass :-)

I believe if there is anything else that we would need to check, @supasate will point it.

@micburks
Copy link

Tested and working! LGTM!

@Oblosys Oblosys mentioned this pull request Jun 21, 2019
@supasate
Copy link
Owner

Thanks @quarties for working on this and thanks everyone for helping test it.

I'm just relocated to another country and messing up with documents, banking, home hunting, new workplace, etc. So, let me merge and release this over the weekend.

@quarties
Copy link
Contributor Author

@supasate take your time, you are doing great work anyway! Good luck with post-relocation issues <3

@quarties
Copy link
Contributor Author

quarties commented Jul 1, 2019

@supasate any news on this?

@supasate supasate merged commit 2c2feaa into supasate:master Jul 2, 2019
@supasate
Copy link
Owner

supasate commented Jul 2, 2019

Released with v6.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants