Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Node22 in CI #750

Merged
merged 1 commit into from
May 7, 2024
Merged

chore: add Node22 in CI #750

merged 1 commit into from
May 7, 2024
+1 −1

Conversation

baseballyama
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 6, 2024 •
edited

⚠️ No Changeset found

Latest commit: f14a12f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama
Copy link
Member Author

I think I need to make a PR to fix these errors.

@baseballyama baseballyama mentioned this pull request May 6, 2024
Merged
@baseballyama baseballyama marked this pull request as draft May 6, 2024 06:09
ota-meshi pushed a commit that referenced this pull request May 7, 2024
@baseballyama
chore: fix tests to follow latest Svelte 5 (#751)
60e784e 
I just added Node 22 but CI does not pass in
#750

sveltejs/svelte#11327 changes warning messages,
so I mainly copied exist tests and optimized for Svelte 5.
@baseballyama baseballyama marked this pull request as ready for review May 7, 2024 01:57
ota-meshi
ota-meshi approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 2dac0a3 into main May 7, 2024
13 checks passed
@ota-meshi ota-meshi deleted the chore/node22 branch May 7, 2024 02:29
@ota-meshi
Copy link
Member

Hmm. CI is failing on the main branch.
eslint-plugin-n was released a few minutes ago so that might be the cause. I'll look into it later.

https://www.npmjs.com/package/eslint-plugin-n?activeTab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baseballyama @ota-meshi