Made error page work #108
Merged
Made error page work #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Nov 4, 2020
ehrencrona
force-pushed
the
error-page
branch
from
62b6371
to
e3202c1
Compare
benmccann
approved these changes
Nov 5, 2020
antony
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error page wasn't loading because a bunch of properties and stores weren't provided.
I solved this the same way we do in Sapper, with a recursive call to
render_pagepassingerrorandstatusas parameters. It seems to work now (except that we referenceprocessin the Hacker News error page and it's not implemented).I also added
errorto the page store as per sveltejs/sapper#1498 and Ben's comment in #6