Run kit package tests in WebKit
#4918
Conversation
Run tests in WebKit, in addition the Chrome
|
|
Failing tests: Not sure how best to recreate these errors locally. [Edit: resolved by 0f66814] |
... Rather than using `deviceDescriptors`. Let's see if this fixes failing tests.
... and removed unused `device` definition, should've been removed in the previous commit
|
@timothycohen, any thoughts? |
|
I agree WebKit should be added to the config. I omitted it from the PR because it adds ~800 tests, and I wanted to first check if the core maintainers had decided to omit it purposefully, or if it simply hadn't been added during the switch to Playwright. I used the same config when testing other than the nested use object 👍 projects: [
{
- name: `${process.env.DEV ? 'dev' : 'build'}+js`,
+ name: `${process.env.DEV ? 'dev' : 'build'}+js+chromium`,
use: {
javaScriptEnabled: true
}
},
{
- name: `${process.env.DEV ? 'dev' : 'build'}-js`,
+ name: `${process.env.DEV ? 'dev' : 'build'}-js+chromium`,
use: {
javaScriptEnabled: false
}
+ },
+ {
+ name: `${process.env.DEV ? 'dev' : 'build'}+js+webkit`,
+ use: {
+ javaScriptEnabled: true,
+ browserName: 'webkit'
+ }
+ },
+ {
+ name: `${process.env.DEV ? 'dev' : 'build'}-js+webkit`,
+ use: {
+ javaScriptEnabled: false,
+ browserName: 'webkit'
+ }
}
], |
... Byproduct of rushed refactor
Not sure what the magic combo is to use Chrome instead of Chromium, while also running WebKit.
Whoops, sloppy refactor, fixed! Huh, but that exposes another problem -- it tries to apply |
|
Latest failing tests: 16, ubuntu-latest16, macOS-latest16, windows-201918, ubuntu-latest |
|
FYI: Addition of |
|
Running this locally (macOS), seems flaky (different tests failing on different runs), which is interesting, that wasn't the case before. Did a bunch of runs (10?), at first it was alternating between A & B (1 failing at a time), then it switched to B & C failing together on the same run, that now seems to be stable. A: B: C: |
|
Summary of latest CI failures: 16, ubuntu-latest: 16, macOS-latest: 16, windows-2019: 18, ubuntu-latest: |
|
Thank you — there's also #5058 (admittedly a more recent PR) which adds Firefox and Safari, and does so in a way that they can run be separate (i.e. concurrent) CI tasks. So I think this PR should be closed in favour of that one — have I got that right? |
|
Merged #5058, so I'll close this — thanks |
Run tests in WebKit, in addition to Chrome (existing behavior).
This builds on #4847, which was (seemingly) inspired by #4065.
According to Statcounter Global Stats (used by Can I use), Safari currently has a global browser market share of 19.16%, second only to Chrome (64.34%). Additionally, all iPhone browsers are powered by WebKit, and iOS has a global mobile OS market share of 27.68%, second only to Android (71.59%).
Thus, it would be worthwhile to know if future changes to this repo cause tests to fail when using WebKit. Thanks to #4847 (mentioned above), they are passing at the moment.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0