Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run kit package tests in WebKit #4918

Closed
wants to merge 12 commits into from
Closed

Run kit package tests in WebKit #4918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4300b0
Run kit package tests in WebKit
mrienstra May 14, 2022
89a7462
utils.js: specify browsers with browserName
mrienstra May 14, 2022
0f66814
utils.js: try different approach to running WebKit
mrienstra May 14, 2022
279a57d
utils.js: `webkit` is more accurate than `safari`
mrienstra May 14, 2022
9ec7477
utils.js: revert unintentional change
mrienstra May 14, 2022
23dcffd
utils.js: remove unnecessary nested `use`
mrienstra May 15, 2022
4950f0b
utils.js: try duplicating channel ref
mrienstra May 15, 2022
27824ff
ci.yml: install playwright browsers
mrienstra May 15, 2022
0070e1f
ci.yml: use npx instead of pnpm exec
mrienstra May 15, 2022
1dd595d
ci.yml: revert changes
mrienstra May 15, 2022
e55e520
kit/package.json: install playwright on build
mrienstra May 15, 2022
774a1d3
Merge branch 'sveltejs:master' into patch-1
mrienstra May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kit/package.json
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@
"svelte-kit.js"
],
"scripts": {
"build": "rollup -c && node scripts/cp.js src/runtime/components assets/components && npm run types",
"build": "rollup -c && node scripts/cp.js src/runtime/components assets/components && npm run types && pnpm exec playwright install --with-deps",
"dev": "rollup -cw",
"lint": "eslint --ignore-path .gitignore --ignore-pattern \"src/packaging/test/**\" \"{src,test}/**/*.{ts,mjs,js,svelte}\" && npm run check-format",
"check": "tsc",
Expand Down
29 changes: 23 additions & 6 deletions packages/kit/test/utils.js
View file
Open in desktop
Expand Up @@ -148,24 +148,41 @@ export const config = {
retries: process.env.CI ? 5 : 0,
projects: [
{
name: `${process.env.DEV ? 'dev' : 'build'}+js`,
name: `${process.env.DEV ? 'dev' : 'build'}+js_chrome`,
use: {
// use stable chrome from host OS instead of downloading one
// see https://playwright.dev/docs/browsers#google-chrome--microsoft-edge
channel: 'chrome',
javaScriptEnabled: true
}
},
{
name: `${process.env.DEV ? 'dev' : 'build'}-js`,
name: `${process.env.DEV ? 'dev' : 'build'}-js_chrome`,
use: {
// use stable chrome from host OS instead of downloading one
// see https://playwright.dev/docs/browsers#google-chrome--microsoft-edge
channel: 'chrome',
javaScriptEnabled: false
}
},
{
name: `${process.env.DEV ? 'dev' : 'build'}+js_webkit`,
use: {
browserName: 'webkit',
javaScriptEnabled: true
}
},
{
name: `${process.env.DEV ? 'dev' : 'build'}-js_webkit`,
use: {
browserName: 'webkit',
javaScriptEnabled: false
}
}
],
use: {
screenshot: 'only-on-failure',
trace: 'retain-on-failure',
// use stable chrome from host OS instead of downloading one
// see https://playwright.dev/docs/browsers#google-chrome--microsoft-edge
channel: 'chrome'
trace: 'retain-on-failure'
},
workers: process.env.CI ? 2 : undefined
};
Expand Down