changed handle_error and index segments #962
Conversation
Right now, the 'segment' prop that is passed to `_layout.svelte` will be undefined for both the index page, and for the error handling page. This will change the segments to `['index']` and `['_error']` respectively. Being able to differentiate between the two pages in the `segment` prop will allow the designer greater control over determining how the page is displayed, such as changing the Nav appearance based upon the segment sent.
| @@ -274,7 +274,8 @@ export async function hydrate_target(target: Target): Promise<{ | |||
| branch?: Array<{ Component: ComponentConstructor, preload: (page) => Promise<any>, segment: string }>; | |||
| }> { | |||
| const { route, page } = target; | |||
| const segments = page.path.split('/').filter(Boolean); | |||
| const segments = page.path === '/' ? ['index'] : page.path.split('/').filter(Boolean); | |||
There was a problem hiding this comment.
Hi! I would also like to have this feature/fix.
So, this change will not allow us to have a route like index? Why not just pass the empty string '' instead? It's basically what we have in url.
|
Given that we're probably going to be removing or at least deprecating |
|
@Conduitry Sounds reasonable, thank You! |
|
It seems like it would be easy enough to put |
|
I'll go ahead and close this given the feedback above. We can consider #1498 as an alternative |
Right now, the 'segment' prop that is passed to
_layout.sveltewill be undefined for both the index page, and for the error handling page. This will change the segments to['index']and['_error']respectively. Being able to differentiate between the two pages in thesegmentprop will allow the designer greater control over determining how the page is displayed, such as changing the Nav appearance based upon the segment sent.Before submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test)