This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Store error in page store (when an error page is triggered)
#1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
benmccann
reviewed
Sep 9, 2020
ehrencrona
commented
Sep 10, 2020
benmccann
reviewed
Sep 10, 2020
benmccann
reviewed
Sep 14, 2020
benmccann
approved these changes
Sep 14, 2020
Merged
ehrencrona
force-pushed
the
store_error_in_page_store
branch
from
f27a32a
to
e6b91ad
Compare
benmccann
reviewed
Sep 21, 2020
benmccann
reviewed
Sep 21, 2020
| @@ -14,7 +14,7 @@ Inside a component, get references to the stores like so: | |||
| ``` | |||
|
|
|||
| * `preloading` contains a readonly boolean value, indicating whether or not a navigation is pending | |||
| * `page` contains a readonly `{ host, path, params, query }` object, identical to that passed to `preload` functions | |||
| * `page` contains a readonly `{ host, path, params, query, error, status }` object. The same value is passed to `preload` functions, though `status` is not present at that time and `error` is only set on error pages. | |||
There was a problem hiding this comment.
I'm wondering now if my suggestion to add status maybe wasn't a good one. I hadn't thought through the fact that it wouldn't be available yet in preload. I wonder if it's that useful in this case and maybe that's too much of a caveat to actually add it
There was a problem hiding this comment.
Yeah, I wouldn't mind removing it again. I generally don't find it particularly useful and the concept of an http status code doesn't really make sense on the client side. I'll take it out again.
|
Looks like this will need to be rebased since your other PR was merged |
ehrencrona
force-pushed
the
store_error_in_page_store
branch
from
3ad205a
to
3aa12a9
Compare
Closed
featherbear
added a commit
to featherbear/CTF2-client
that referenced
this pull request
Sep 28, 2020
Updated Sapper to 0.28.9 --- sveltejs/sapper#948 sveltejs/sapper#1498
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #948, store the current error in the
pagestore to allow the layout to know whether the current page is an error page (as per suggestion by @Conduitry).My first PR in this project, so very open to feedback :)
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint