Avoid creating new node processes by leveraging processAsync

[benmccann]

Closes #25

[sebastianrothe]

Do you think we can get rid of CJS completely and move all files to ESM ?

[sebastianrothe]

I think we need to enforce a version of Jest >= 27, because it won't run with Jest 26 anymore. You got that already, sorry.

[benmccann]

Do you think we can get rid of CJS completely and move all files to ESM ?

I'd be in favor of that. It seems unrelated to this PR and best to do in a new one though

[sebastianrothe]

Do you think we can get rid of CJS completely and move all files to ESM ?

I'd be in favor of that. It seems unrelated to this PR and best to do in a new one though

I'm so sorry, but I disabled most of the tests with one of my older commits :(

https://github.com/mihar-22/svelte-jester/pull/53/files#diff-f638d82910738e07f34f9ca5c6cb2a01c223570f9c2425ddf60f61e2070c169dR64

[benmccann]

I'm so sorry, but I disabled most of the tests with one of my older commits :(

at least you're not alone in making that exact mistake... sveltejs/kit#2069 (comment)

[mihar-22]

PR LGTM! Feel free to merge when you're ready. Excited about this and also interested in moving to ESM in another PR if anyone is down for it. Happy to cut a release once we get that done.

[benmccann]

Cool. I guess the main thing is getting the tests re-enabled first. Is that something you're looking at @sebastianrothe ?

[sebastianrothe]

Yes, I have them running, but I had to switch everything to ESM. Don't know if that's okay, or if we should keep CJS as well.

[benmccann]

I'd say go ahead and switch it to ESM

[sebastianrothe]

Please have a look.

[sebastianrothe]

I'd say go ahead and switch it to ESM

I guess someone could run the code through Babel/Bundler and output a CJS version of it.

[benmccann]

LGTM

[mihar-22]

Thanks for the work on this PR @benmccann and @sebastianrothe! Released in 1.8.0 🥳

[mihar-22]

Oh crap. I was meant to major bump...

[mihar-22]

Made a mess but all resolved and released in 2.0.0.

[benmccann]

thanks!!