Disable convertStyleToAttrs plugin by default #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #1362 #1360 From the [spec](https://www.w3.org/TR/SVG11/styling.html#UsingPresentationAttributes): > Presentation attributes have lower priority than other CSS style rules specified in author style sheets or ‘style’ attributes. Though we replace inline styles with attributes without checking if thare is any `<style>` element. This makes the plugin unsafe and it should not be enabled by default.
|
@TrySound: I agree that it should be disabled by default until better logic is added that takes the specificity into account. |
This was referenced Feb 22, 2021
This was referenced Mar 7, 2021
This was referenced May 21, 2021
chore(deps): update dependency svgo to v2 - autoclosed
fisker/serve-directory-theme-city-lights#1346
Closed
This was referenced Jun 6, 2021
This was referenced Jun 6, 2021
This was referenced Jun 30, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1362 #1360
From the spec:
Though we replace inline styles with attributes without checking if
thare is any
<style>element. This makes the plugin unsafe and itshould not be enabled by default.
cc @sk- @strarsis