CLI changes [CPP-585]

[notoriaga]

No description provided.

[notoriaga]

A little annoying we have to use this intermediate struct but i can't figure out a way around it within the logging facade. Switching to &str avoids some allocations when reading strings back into this struct

[notoriaga]

With tabs everything is "jagged", this is kind of a hack but looks nicer? Could go either way on this

[john-michaelburke]

I see mentions of Arg Groups here: clap-rs/clap#2621 but it doesn't seem to affect sorting of the help blurb, still would be good for some of our grouped commands. I think for ordering we may be forced to hardcode the help blurb which is kind of a shame. I think we can push that off closer to launch if we happen to add/change any other CLI args until then.

[john-michaelburke]

rebase then

[notoriaga]

There is also a way to manually specify the ordering (or make it follow the struct def), but can't figure out how to get the help flags in the right place

[john-michaelburke]

There is also a way to manually specify the ordering (or make it follow the struct def), but can't figure out how to get the help flags in the right place

Maybe this display_order https://github.com/clap-rs/clap/pull/443/files#diff-561c554f836a4672327d4b2e507d4ff173876ee9b3a6d6623fc0d7aaa649159dR160

[notoriaga]

This is what it looks like now

USAGE:
    swift-navigation-console [OPTIONS] [SUBCOMMAND]

OPTIONS:
        --sbp-log <SBP_LOG>
            Log SBP-JSON or SBP data to default / specified log file

        --sbp-log-filename <SBP_LOG_FILENAME>
            Set SBP log filename

        --log-dirname <LOG_DIRNAME>
            Set log directory

        --log-console
            Create a log file containing console debug information

        --csv-log
            Log CSV data to default / specified log file

        --show-csv-log
            Show CSV logging button

        --show-fileio
            Show Filio pane in Update tab

        --show-file-connection
            Allow File Connections

        --settings-yaml <SETTINGS_YAML>
            Path to a yaml file containing known piski settings

        --use-opengl
            Use OpenGL, plots will become optimized for efficiency not aesthetics and require less
            system resources

        --refresh-rate <REFRESH_RATE>
            Change the refresh rate of the plots

        --no-prompts
            Don't show prompts about firmware/console updates

        --exit-after
            Exit when connection closes

        --tab <TAB>
            Start console from specific tab

        --height <HEIGHT>
            Set the height of the main window

        --width <WIDTH>
            Set the width of the main window

    -h, --help
            Print help information

    -V, --version
            Print version information

SUBCOMMANDS:
    serial    
    tcp       
    file      
    help      Print this message or the help of the given subcommand(s)

Ticket didn't mention show-file-connection/no-prompts so not sure if they are in the right spot

[notoriaga]

This fixes the name locally, not sure if that was still and issue with dists?