Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for rounding_mode #13138

Merged
merged 1 commit into from Mar 16, 2020
Merged

Conversation

VincentLanglet
Copy link
Contributor

@wouterj wouterj added the Waiting Code Merge Docs for features pending to be merged label Feb 14, 2020
@HeahDude HeahDude added this to the next milestone Feb 19, 2020
@HeahDude HeahDude added the Form label Feb 19, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Mar 16, 2020
…a rounding_mode option (VincentLanglet)

This PR was squashed before being merged into the 5.1-dev branch.

Discussion
----------

[Form] Correctly round model with PercentType and add a rounding_mode option

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35296
| License       | MIT
| Doc PR        | symfony/symfony-docs#13138

Commits
-------

d97565d [Form] Correctly round model with PercentType and add a rounding_mode option
symfony-splitter pushed a commit to symfony/form that referenced this pull request Mar 16, 2020
…a rounding_mode option (VincentLanglet)

This PR was squashed before being merged into the 5.1-dev branch.

Discussion
----------

[Form] Correctly round model with PercentType and add a rounding_mode option

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35296
| License       | MIT
| Doc PR        | symfony/symfony-docs#13138

Commits
-------

d97565dcee [Form] Correctly round model with PercentType and add a rounding_mode option
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Mar 16, 2020
@javiereguiluz
Copy link
Member

Vincent, thanks for contributing both the code and the docs for this feature! Merged.

@javiereguiluz javiereguiluz merged commit efc8f70 into symfony:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants