Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Correctly round model with PercentType and add a rounding_mode option #35729

Merged
merged 1 commit into from Mar 16, 2020
Merged

[Form] Correctly round model with PercentType and add a rounding_mode option #35729

merged 1 commit into from Mar 16, 2020

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Feb 14, 2020 •
edited

Q A
Branch? master
Bug fix? yes
New feature? yes
Deprecations? no
Tickets Fix #35296
License MIT
Doc PR symfony/symfony-docs#13138

This was referenced Feb 14, 2020
Closed
Merged
@VincentLanglet VincentLanglet force-pushed the roundPercentTypeValue branch 2 times, most recently from 24eb4c3 to 8b3de3c Compare February 14, 2020 23:17
@VincentLanglet VincentLanglet marked this pull request as ready for review February 14, 2020 23:32
@nicolas-grekas nicolas-grekas changed the title Correctly round model with PercentType and add a rounding_mode option [Form] Correctly round model with PercentType and add a rounding_mode option Feb 15, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 15, 2020
@VincentLanglet
Copy link
Contributor Author

@nicolas-grekas I made the PR on master because I added an option rounding_mode.

But I kinda consider as a bug the fact the value is not rounded in 3.4, 4.4 and 5.0 versions. Should I make a bugfix PR on theses versions with only the round function but no rounding_mode parameter ?

@VincentLanglet
Copy link
Contributor Author

If the PR #35781 is accepted, I'll need to include the same fix.

@VincentLanglet
Copy link
Contributor Author

@nicolas-grekas @xabbuh Hi ! Is something missing with this PR ? :)

@fabpot
Copy link
Member

fabpot commented Mar 16, 2020

Thank you @VincentLanglet.

@fabpot fabpot merged commit 06a1a1b into symfony:master Mar 16, 2020
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 16, 2020
@javiereguiluz
minor #13138 Add doc for rounding_mode (VincentLanglet)
efc8f70 
This PR was merged into the master branch.

Discussion
----------

Add doc for rounding_mode

Related to symfony/symfony#35729

Commits
-------

fcc8641 Add doc for rounding_mode
@xabbuh xabbuh mentioned this pull request Apr 25, 2020
Merged
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Form "PercentType" parameter "scale" inconsistency with "NumberType"
5 participants
@VincentLanglet @fabpot @nicolas-grekas @OskarStark @carsonbot