[Translation] prefer intl domain when adding messages to catalogue #35370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guite
changed the title
Guite
changed the title
welcoMattic
approved these changes
Jan 18, 2020
|
If this is a bug fix, I suppose it should target a lower branch? |
Should I target
I will try, but it may take a little while. |
|
Closing in favour of #35430 which targets |
fabpot
added a commit
that referenced
this pull request
Feb 3, 2020
…atalogue (Guite) This PR was squashed before being merged into the 4.4 branch (closes #35430). Discussion ---------- [Translation] prefer intl domain when adding messages to catalogue | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This PR ensures that when adding translations to a catalogue using the `add(array $messages, string $domain = 'messages')` method internally the intl icu domain is checked first. Otherwise it could happen that existing messages in e.g. `messages+intl-icu` are not updated but the same keys are added to `messages`. This is a follow-up of #35370, now targeting the `4.4` branch. Commits ------- b72b7d3 [Translation] prefer intl domain when adding messages to catalogue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when adding translations to a catalogue using the
add(array $messages, string $domain = 'messages')method internally the intl icu domain is checked first.Otherwise it could happen that existing messages in e.g.
messages+intl-icuare not updated but the same keys are added tomessages.