[Mailer][DX] Add notice log when email recipients are not defined #35818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Mailer
DX
jschaedl
reviewed
Feb 21, 2020
| @@ -65,6 +65,8 @@ public function send(RawMessage $message, Envelope $envelope = null): ?SentMessa | |||
| } | |||
|
|
|||
| if (!$envelope->getRecipients()) { | |||
| $this->getLogger()->notice('There are no recipients in the mailer envelope. Nothing was sent.'); | |||
There was a problem hiding this comment.
I would have expected a LogicException and a hint about what I can do to fix the problem.
There was a problem hiding this comment.
@jschaedl i did not know the logic behind the « ?SentMessage » method return signature
that is why i added a log and not thrown ex and remove the return null
Maybe we need to wait other review comment :)
|
I've fixed the root issue(s) in #36467 |
fabpot
added a commit
that referenced
this pull request
Apr 16, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Mailer from sender fixes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #35818, Fix #35805, Fix #33753 | License | MIT | Doc PR | n/a Commits ------- e885860 Fix From/Sender handling in Emails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Add a log in order to be aware that no email was sent due to bad data
IF the PR is accepted, is the log level
noticethe right one?thx