Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer][DX] Add notice log when email recipients are not defined #35818

Closed
wants to merge 1 commit into from
Closed

[Mailer][DX] Add notice log when email recipients are not defined #35818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/Mailer/Transport/AbstractTransport.php
View file
Open in desktop
Expand Up @@ -65,6 +65,8 @@ public function send(RawMessage $message, Envelope $envelope = null): ?SentMessa
}

if (!$envelope->getRecipients()) {
$this->getLogger()->notice('There are no recipients in the mailer envelope. Nothing was sent.');
Copy link
Contributor

@jschaedl jschaedl Feb 21, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected a LogicException and a hint about what I can do to fix the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschaedl i did not know the logic behind the « ?SentMessage » method return signature

that is why i added a log and not thrown ex and remove the return null

Maybe we need to wait other review comment :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendly ping @fabpot as you have commented on related issue #33753


return null;
}

Expand Down