[FrameworkBundle] Deprecate flashbag and attributebag services #36273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warslett
changed the title
warslett
force-pushed
the
deprecate-flashbag-and-attributebag-services
branch
from
63fef32
to
2e4bc95
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Mar 31, 2020
Tobion
approved these changes
Mar 31, 2020
nicolas-grekas
approved these changes
Mar 31, 2020
warslett
force-pushed
the
deprecate-flashbag-and-attributebag-services
branch
from
f35df01
to
4baed97
Compare
|
rebased to resolve conflicts |
|
Actually, please rebase again to account for #35778, thanks :) |
|
@nicolas-grekas rebased and now using new deprecated attributes. Nice feature @atailouloute |
fabpot
approved these changes
Apr 1, 2020
|
Thank you @warslett. |
fabpot
force-pushed
the
deprecate-flashbag-and-attributebag-services
branch
from
298452a
to
f9b52fe
Compare
Merged
|
I agree that this shouldn't be injected, however i'm running into an issue with this deprecation, namely: The Maybe this method should be added to the interface? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlashBag and AttributeBag are data objects and so should not be available via the service container. The preferred method for accessing these objects is via
$session->getFlashBag()or$session->getAttributeBag()