[ErrorHandler] Skip failing tests when "xdebug.file_link_format" option is defined #54278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 13, 2024
| @@ -27,6 +27,11 @@ public function testWhenNoFileLinkFormatAndNoRequest() | |||
|
|
|||
| public function testAfterUnserialize() | |||
| { | |||
| if (get_cfg_var('xdebug.file_link_format')) { | |||
There was a problem hiding this comment.
shouldn't this use ini_get instead ?
There was a problem hiding this comment.
Nope. I don't use xdebug. So the param is not available via ini_get. See the implementation of the file link formatter
src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php
Show resolved
Hide resolved
nicolas-grekas
requested review from
xabbuh,
dunglas,
welcoMattic,
kbond,
chalasr,
OskarStark and
jderusse
as code owners
nicolas-grekas
force-pushed
the
error-handler-tests-config
branch
from
8770975
to
05ad85d
Compare
|
Thank you @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test annoys me since ... many years!
So let's skip it.