Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ErrorHandler] Skip failing tests when "xdebug.file_link_format" option is defined #54278

Merged
merged 1 commit into from Mar 13, 2024
Merged

[ErrorHandler] Skip failing tests when "xdebug.file_link_format" option is defined #54278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Symfony/Component/ErrorHandler/Tests/ErrorRenderer/FileLinkFormatterTest.php
View file
Open in desktop
Expand Up @@ -27,6 +27,11 @@ public function testWhenNoFileLinkFormatAndNoRequest()

public function testAfterUnserialize()
{
if (get_cfg_var('xdebug.file_link_format')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this use ini_get instead ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I don't use xdebug. So the param is not available via ini_get. See the implementation of the file link formatter

// There is not way to override "xdebug.file_link_format" option in a test.
nicolas-grekas marked this conversation as resolved.
Show resolved Hide resolved
$this->markTestSkipped('php.ini has a custom option for "xdebug.file_link_format".');
}

$ide = $_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? null;
$_ENV['SYMFONY_IDE'] = $_SERVER['SYMFONY_IDE'] = null;
$sut = unserialize(serialize(new FileLinkFormatter()));
Expand Down