Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of reference links with inline code #25

Merged
merged 3 commits into from Sep 19, 2021
Merged

Fix handling of reference links with inline code #25

merged 3 commits into from Sep 19, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Sep 19, 2021

This fixes the AST so that certain kinds of reference links are not
broken when converted back to markdown.

Fixes: remarkjs/remark#850

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This fixes text content (“phrasing”, such as emphasis or code) inside labels (of links, images).

Trott and others added 3 commits September 18, 2021 18:30
@Trott
Fix handling of reference links with inline code
c53a2be 
This fixes the AST so that certain kinds of reference links are not
broken when converted back to markdown.

Fixes: remarkjs/remark#850
@wooorm
Merge branch 'reflinks' of https://github.com/Trott/mdast-util-from-m…
9492217 
…arkdown into Trott-reflinks

* 'reflinks' of https://github.com/Trott/mdast-util-from-markdown:
  Fix handling of reference links with inline code
@wooorm
Fix label on link, image if w/ phrasing
06bce3b 
Closes GH-24.
Closes remarkjs/remark#850.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 19, 2021
@wooorm wooorm added 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface 🙆 yes/confirmed This is confirmed and ready to be worked on and removed 🤞 phase/open Post is being triaged manually labels Sep 19, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the 👍 phase/yes Post is accepted and can be worked on label Sep 19, 2021
@github-actions

This comment has been minimized.

Sign in to view
wooorm
wooorm commented Sep 19, 2021
View reviewed changes
Copy link
Member Author

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@wooorm wooorm merged commit a90b930 into main Sep 19, 2021
@wooorm wooorm deleted the label-phrasing branch September 19, 2021 12:30
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 19, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on 🙆 yes/confirmed This is confirmed and ready to be worked on labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stringify() appears to mishandle reference links with inline code
2 participants
@wooorm @Trott