-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't escape plus not followed by a whitespace #57
Conversation
This comment has been minimized.
This comment has been minimized.
Some issues about the CI:
|
type-coverage is not coverage, it’s something else. I’ve updated the internal types for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try and improve the -
case with {atBreak: true, character: '-', after: '(?:[ \t\r\n\-])'}
, and the *
case with {atBreak: true, character: '*', after: '(?:[ \t\r\n\*])'}
6ae93f9
to
a0f9da1
Compare
The CI is green after rebasing the latest If I improve the |
This comment has been minimized.
This comment has been minimized.
These test check for something that was being escaped, but did not strictly need to be escaped. See 2f3eeb7 |
Released, thanks! https://github.com/syntax-tree/mdast-util-to-markdown/releases/tag/1.4.0 |
Initial checklist
Description of changes
This PR improves the escape unsafe rule for
+
. If a+
is not followed by[\ \t\r\n]
, then it won't turn into a list item, thus we don't need to escape it.