Fix TypeScript node16 and ESM
#12
Conversation
github-actions
bot
added
👋 phase/new
package.json
Outdated
| "type-coverage": "^2.0.0", | ||
| "typescript": "^4.0.0", | ||
| "typescript": ">=4.7", |
There was a problem hiding this comment.
| "typescript": ">=4.7", | |
| "typescript": "^4.0.0", |
Can you revert this?
The style we use here is to have relaxed ranges except when they are really needed.
There was a problem hiding this comment.
I think it's truly needed in this case. It would allow TS 4.6 and older otherwise, which can't build this project.
There was a problem hiding this comment.
It’s not needed. The TypeScript dependency isn’t different from any other. Version ^4.0.0 will resolve to TypeScript 4.7 (at the moment of writing). If you run into issues, try deleting node_modules and running npm install.
|
Don't merge yet, please! |
|
You mean the range? I find both fine. |
|
Ah, I refer to the re-exporting of types, it isn't working as intended, figuring out a better solution. |
|
ahh, right, thanks for spotting that, I was mixing the conversations on two PRs! |
|
No worries! Tests pass, ready to be merged now. |
wooorm
added
🐛 type/bug
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
|
Thanks, released! |
Closes GH-35. Related-to: syntax-tree/mdast-util-mdxjs-esm#3. Related-to: syntax-tree/unist-util-visit-parents#12. Reviewed-by: JounQin <admin@1stg.me> Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Initial checklist
Description of changes
See syntax-tree/mdast-util-mdxjs-esm#3.
Blocks syntax-tree/unist-util-visit#35.