Upgrading dependencies and switching build to all rollup #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
guybedford
approved these changes
Apr 1, 2020
| "min": "npm run min:systemjs && npm run min:sjs", | ||
| "min:systemjs": "cd dist && terser system.js -c passes=2 -m --source-map --comments \"/SystemJS \\d/\" -o system.min.js", | ||
| "min:sjs": "cd dist && terser s.js -c passes=2 -m --source-map -o s.min.js", | ||
| "build": "rimraf dist && rollup -c", |
There was a problem hiding this comment.
We should retain a build mode / option that allows skipping minification here for quick builds in development.
I seem to recall there may even be a way with RollupJS to pass options, but can't remember if that is correct. Otherwise environment variables can work too.
There was a problem hiding this comment.
You can with rollup's --environment flag
src/system-core.js
Outdated
| if (name.__esModule) { | ||
| ns.__esModule = name.__esModule; | ||
| if (name[__esModule]) { | ||
| ns[__esModule] = name[__esModule]; |
There was a problem hiding this comment.
This isn't necessary because it shouldn't affect the gzip size.
| * Minimal SystemJS Build | ||
| */` : `/* | ||
| * SystemJS ${version} | ||
| */` |
There was a problem hiding this comment.
Indentation here needs to shift back two spaces.
|
I verified that the browser tests work in chrome, ff, safari 13, edge, and IE11, with both system.js and system.min.js. |
This was referenced May 2, 2020
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
//# sourceMappingURLcomment to minified output. This accounts for some of the byte size increases.The motivation for this change was a susbsequent change that adds error codes to reduce the bundle size further.
I haven't tested all the minified files in a browser yet, but will do so in ie, safari, ff, and chrome if this becomes ready to merge.