Upgrading dependencies and switching build to all rollup #2149
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,113 @@ | ||
| import replace from '@rollup/plugin-replace'; | ||
| import fs from 'fs'; | ||
| import path from 'path'; | ||
| import { terser } from 'rollup-plugin-terser'; | ||
|
|
||
| const version = JSON.parse(fs.readFileSync('package.json')).version; | ||
| const extras = fs.readdirSync(path.resolve(__dirname, 'src/extras')); | ||
|
|
||
| const terserOptions = { | ||
| mangle: { | ||
| eval: true, | ||
| module: true, | ||
| safari10: true, | ||
| toplevel: true | ||
| }, | ||
| parse: { | ||
| }, | ||
| compress: { | ||
| unsafe: true, | ||
| arguments: true, | ||
| hoist_funs: true, | ||
| hoist_props: true, | ||
| keep_fargs: false, | ||
| negate_iife: true, | ||
| module: true, | ||
| pure_getters: true, | ||
| passes: 2, | ||
| sequences: 400, | ||
| toplevel: true, | ||
| unsafe_proto: true, | ||
| unsafe_regexp: true, | ||
| unsafe_math: true, | ||
| unsafe_symbols: true, | ||
| unsafe_comps: true, | ||
| unsafe_Function: true, | ||
| unsafe_undefined: true | ||
| }, | ||
| output: { | ||
|
There was a problem hiding this comment. Indentation here needs to shift back two spaces. |
||
| comments(node, comment) { | ||
| return /^\* SystemJS [0-9]\./.test(comment.value.trim()); | ||
| }, | ||
| safari10: true | ||
| }, | ||
| ecma: 5, // specify one of: 5, 2015, 2016, 2017 or 2018 | ||
| keep_classnames: false, | ||
| keep_fnames: false, | ||
| ie8: false, | ||
| module: true, | ||
| nameCache: null, // or specify a name cache object | ||
| safari10: true, | ||
| toplevel: true, | ||
| warnings: false | ||
| }; | ||
|
|
||
| export default [ | ||
| mainConfig('system', true), | ||
| mainConfig('system', false), | ||
| mainConfig('s', true), | ||
| mainConfig('s', false), | ||
| ...extrasConfig(true), | ||
| ...extrasConfig(false) | ||
| ]; | ||
|
|
||
| function mainConfig(name, isDev) { | ||
| const sjs = name === 's'; | ||
| let banner; | ||
| if (sjs) { | ||
| banner = isDev ? `/* | ||
| * SJS ${version} | ||
| * Minimal SystemJS Build | ||
| */` : null; | ||
| } else { | ||
| banner = `/* | ||
| * SystemJS ${version} | ||
| */`; | ||
| } | ||
|
|
||
| return { | ||
| input: `src/${name}.js`, | ||
| output: { | ||
| file: `dist/${name}${isDev ? '' : '.min'}.js`, | ||
| format: 'iife', | ||
| strict: false, | ||
| sourcemap: !isDev, | ||
| banner | ||
| }, | ||
| plugins: [ | ||
| replace({ | ||
| TRACING: sjs ? 'false' : 'true', | ||
| }), | ||
| !isDev && terser(terserOptions) | ||
| ] | ||
| }; | ||
| } | ||
|
|
||
| function extrasConfig(isDev) { | ||
| return extras.map(extra => { | ||
| extra = extra.replace('.js', ''); | ||
| return { | ||
| input: `src/extras/${extra}.js`, | ||
| output: { | ||
| file: `dist/extras/${extra}${isDev ? '' : '.min'}.js`, | ||
| format: 'iife', | ||
| strict: false, | ||
| compact: true, | ||
| sourcemap: !isDev | ||
| }, | ||
| plugins: [ | ||
| !isDev && terser(terserOptions) | ||
| ] | ||
| }; | ||
| }); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should retain a build mode / option that allows skipping minification here for quick builds in development.
I seem to recall there may even be a way with RollupJS to pass options, but can't remember if that is correct. Otherwise environment variables can work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can with rollup's
--environmentflag