Ensure FocusTrap is only active when the given enabled value is true
#2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@milhamm is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
milhamm
changed the title
milhamm
changed the title
Tabs that contains a Dialog
milhamm
changed the title
Tabs that contains a DialogTabs that contains a Dialog
milhamm
commented
Apr 26, 2023
This will allow us to make the code relatively similar between React and Vue.
RobinMalfait
changed the title
Tabs that contains a DialogFocusTrap is only active when the given enabled value is true
|
Hey, thanks so much for this contribution! 🙏 While your fix worked as expected, there was a bigger problem going on where the I also ported the fix + test to the Vue version. The added test was very helpful, thanks! |
|
Hey @RobinMalfait, thanks for sorting out the root cause of the problem. Quick question: would it be okay if I also update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tab focus is wrong when navigating on a
Tabcontaining aDialogcomponent.Previous Behavior
Screencast.from.04-26-2023.04.22.32.PM.webm
This PR Fix
Screencast.from.04-26-2023.04.23.58.PM.webm
Fixes #2406