Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure FocusTrap is only active when the given enabled value is true #2456

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Ensure FocusTrap is only active when the given enabled value is true #2456

merged 7 commits into from
Apr 26, 2023

Commits on Apr 26, 2023

  1. fix(tabs): wrong tab focus when Tab contains a Dialog

    @milhamm
    milhamm committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    3e61de7 View commit details
    Browse the repository at this point in the history

  2. refactor(focus-trap): rename variable and move logic

    @milhamm
    milhamm committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    90dd2c8 View commit details
    Browse the repository at this point in the history

  3. test(tabs): improve test by asserting the active element

    @milhamm
    milhamm committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5531d45 View commit details
    Browse the repository at this point in the history

  4. ensure FocusTrap is not active when enabled = false

    @RobinMalfait
    RobinMalfait committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    547d795 View commit details
    Browse the repository at this point in the history

  5. fix: move the enabled check to unmounting

    @milhamm
    milhamm committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    fc594eb View commit details
    Browse the repository at this point in the history

  6. refactor to useOnUnmount hook 

    This will allow us to make the code relatively similar between React and
Vue.
    @RobinMalfait
    RobinMalfait committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    720c8d1 View commit details
    Browse the repository at this point in the history

  7. update changelog

    @RobinMalfait
    RobinMalfait committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2dd8319 View commit details
    Browse the repository at this point in the history