Disable smooth scrolling when opening/closing Dialog components on iOS
#2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For iOS workaround related purposes we have to capture the scroll position and offset the margin top with that amount and then `scrollTo(0,0,)` to prevent all kinds of funny UI jumps. However, if you have `scroll-behavior: smooth` enabled on your `html`, then offseting the margin-top and later `scrollTo(0,0)` would be handled in a smooth way, which means that the actual position would be off. To solve this, we disable smooth scrolling entirely in order to make the position of the Dialog correct. This shouldn't be a problem in practice since the page itself isn't suppose to scroll anyway. Once the Dialog closes we reset it such that everything else keeps working as expected in a (smooth) way.
RobinMalfait
force-pushed
the
fix/issue-2522
branch
from
5778e9b
to
739042f
Compare
RobinMalfait
force-pushed
the
fix/issue-2522
branch
from
739042f
to
833bcec
Compare
RobinMalfait
force-pushed
the
fix/issue-2522
branch
from
cb0f334
to
3735db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
Dialogopening/closing behavior on iOS if you enabledscroll-behavior: smooth;For iOS workaround related purposes we have to capture the scroll position and offset the margin top with that amount and then
scrollTo(0,0,)to prevent all kinds of funny UI jumps.However, if you have
scroll-behavior: smoothenabled on yourhtml, then offseting the margin-top and laterscrollTo(0,0)would be handled in a smooth way, which means that the actual position would be off.To solve this, we disable smooth scrolling entirely in order to make the position of the Dialog correct. This shouldn't be a problem in practice since the page itself isn't suppose to scroll anyway.
Once the Dialog closes we reset it such that everything else keeps working as expected in a (smooth) way.
Fixes: #2522